Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return types for MurmurHash3_x86_32 template specializations #17622

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Fix return types for MurmurHash3_x86_32 template specializations #17622

merged 1 commit into from
Dec 19, 2024

Conversation

davidwendt
Copy link
Contributor

Description

Changes the return types for the MurmurHash3_x86_32 specialization functions to match the declarations in the struct.
Hoping to fix some intellisense squiggles.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 18, 2024
@davidwendt davidwendt self-assigned this Dec 18, 2024
@davidwendt davidwendt requested a review from a team as a code owner December 18, 2024 14:50
kingcrimsontianyu
kingcrimsontianyu approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@kingcrimsontianyu kingcrimsontianyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

PointKernel
PointKernel approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@PointKernel PointKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Probably need to do the same for other hashers as well.

@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0e01dbd into rapidsai:branch-25.02 Dec 19, 2024
109 checks passed
@davidwendt davidwendt deleted the murmurhash32-return-type branch December 19, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PointKernel PointKernel PointKernel approved these changes

@kingcrimsontianyu kingcrimsontianyu kingcrimsontianyu approved these changes

@ttnghia ttnghia ttnghia approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidwendt @ttnghia @kingcrimsontianyu @PointKernel